Skip to content

fix: Move sagemaker-mlflow to extras #4903

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Nov 5, 2024
Merged

fix: Move sagemaker-mlflow to extras #4903

merged 3 commits into from
Nov 5, 2024

Conversation

ryansteakley
Copy link
Contributor

Issue #, if available:
#4885
Description of changes:
move sagemaker-mlflow to extras
Testing done:
pip install sagemaker
pip install sagemaker[sagemaker-mlflow]

Merge Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.

General

  • [ x] I have read the CONTRIBUTING doc
  • [x ] I certify that the changes I am introducing will be backward compatible, and I have discussed concerns about this, if any, with the Python SDK team
  • [x ] I used the commit message format described in CONTRIBUTING
  • [ x] I have passed the region in to all S3 and STS clients that I've initialized as part of this change.
  • [ x] I have updated any necessary documentation, including READMEs and API docs (if appropriate)

Tests

  • I have added tests that prove my fix is effective or that my feature works (if appropriate)
  • I have added unit and/or integration tests as appropriate to ensure backward compatibility of the changes
  • I have checked that my tests are not configured for a specific region or account (if appropriate)
  • I have used unique_name_from_base to create resource names in integ tests (if appropriate)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@ryansteakley ryansteakley requested a review from a team as a code owner October 17, 2024 19:12
@ryansteakley ryansteakley mentioned this pull request Oct 17, 2024
Closed
@ryansteakley ryansteakley force-pushed the sagemaker-mlflow-extras branch from 12ba2ec to 98e8833 Compare October 17, 2024 20:10
@benieric
Copy link
Collaborator 

  File "<string>", line 1, in <module>
  File "/.pyenv/versions/3.8.18/lib/python3.8/site-packages/sagemaker/__init__.py", line 18, in <module>
    from sagemaker import estimator, parameter, tuner  # noqa: F401
  File "/.pyenv/versions/3.8.18/lib/python3.8/site-packages/sagemaker/estimator.py", line 110, in <module>
    from sagemaker.mlflow.forward_sagemaker_metrics import log_sagemaker_job_to_mlflow
  File "/.pyenv/versions/3.8.18/lib/python3.8/site-packages/sagemaker/mlflow/forward_sagemaker_metrics.py", line 23, in <module>
    import mlflow
ModuleNotFoundError: No module named 'mlflow'

This should be handled gracefully so importing estimator does not fail if sagemaker-mlflow is not installed

@benieric
Copy link
Collaborator

in the sagemaker/mlflow/forward_sagemaker_metrics.py we can raise custom import error warning user to install pip install sagemaker[sagemaker-mlflow] if they want to use

@ryansteakley ryansteakley force-pushed the sagemaker-mlflow-extras branch from 0cf870c to fe9d105 Compare October 21, 2024 17:45
@ryansteakley ryansteakley force-pushed the sagemaker-mlflow-extras branch from fe9d105 to 6aa6822 Compare October 22, 2024 20:03
@ryansteakley ryansteakley force-pushed the sagemaker-mlflow-extras branch from 32ec377 to a126c5d Compare October 23, 2024 01:21
@ryansteakley ryansteakley force-pushed the sagemaker-mlflow-extras branch from e39d724 to abcce37 Compare October 24, 2024 19:41
@ryansteakley ryansteakley force-pushed the sagemaker-mlflow-extras branch from 3660f79 to 3e5e567 Compare November 1, 2024 18:59
@benieric benieric merged commit 292a00d into aws:master Nov 5, 2024
14 checks passed
ashishgupta023 pushed a commit to ashishgupta023/sagemaker-python-sdk that referenced this pull request Nov 12, 2024
Revert "fix: Move sagemaker-mlflow to extras (aws#4903)"
41cad2d 
This reverts commit 292a00d.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benieric benieric benieric approved these changes

@mohanasudhan mohanasudhan Awaiting requested review from mohanasudhan mohanasudhan is a code owner automatically assigned from aws/sagemaker-ml-frameworks

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ryansteakley @benieric